Skip to content

Support PHP 7.1-8.0 #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Support PHP 7.1-8.0 #162

merged 1 commit into from
Jul 13, 2020

Conversation

GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Jul 13, 2020

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Related tickets fixes #159
License MIT

Switches to GitHub actions and supports php 7.1-8.0. Note that travis needs to be removed from the required to pass CI thing.

Co-Authored-By: Márk Sági-Kazár <[email protected]>
@GrahamCampbell
Copy link
Contributor Author

// cc @dbu, @sagikazarmark

@GrahamCampbell GrahamCampbell marked this pull request as ready for review July 13, 2020 12:01
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dbu dbu merged commit bfd345b into php-http:master Jul 13, 2020
@GrahamCampbell GrahamCampbell deleted the php8 branch July 13, 2020 15:31
@dbu
Copy link
Contributor

dbu commented Jul 13, 2020

i merged this, but the build of master is now failing. the problem is that we try to build on travis with php 7.0:

- 7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants